Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add additional Qt modules and more support and tests for PyQt6/PySide6 #255

Merged
merged 2 commits into from
Oct 21, 2021
Merged

PR: Add additional Qt modules and more support and tests for PyQt6/PySide6 #255

merged 2 commits into from
Oct 21, 2021
+371 −56

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Oct 15, 2021 •
edited
Loading

new modules and more support for pyqt6/pyside6 for existing modules, tests

@jschueller jschueller force-pushed the pyqt6 branch 6 times, most recently from e2861fe to e9a4797 Compare October 15, 2021 23:36
@CAM-Gerlach CAM-Gerlach requested a review from dalthviz October 16, 2021 22:34
@CAM-Gerlach CAM-Gerlach changed the title More modules PR: Add additional Qt modules and more support and tests for PyQt6/PySide6 for existing Oct 16, 2021
@dalthviz dalthviz added this to the v2.0.0 milestone Oct 18, 2021
dalthviz
dalthviz reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller for all the work here! I left some suggestions and overall feedback.

Also, I think something missing could be the addition of the CI support for PyQt6. Let us know if you want to work on that here too!

qtpy/Qt3DCore.py Outdated Show resolved Hide resolved
qtpy/Qt3DExtras.py Show resolved Hide resolved
qtpy/Qt3DInput.py Outdated Show resolved Hide resolved
qtpy/Qt3DLogic.py Outdated Show resolved Hide resolved
qtpy/Qt3DRender.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtsensors.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtwebenginecore.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtwebenginewidgets.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtwebenginewidgets.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtxml.py Outdated Show resolved Hide resolved
@dalthviz
Copy link
Member

This is related with #233

@jschueller
Copy link
Contributor Author

jschueller commented Oct 20, 2021 •
edited
Loading

I wont have time to enable pyqt6 CI

@CAM-Gerlach
Copy link
Member

I can help take care of it along with #253 after this PR is in, assuming #233 is mostly resolved by then (at least to the point where CI testing is reasonable)

dalthviz
dalthviz reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller for the changes. I left some more comments 👍

qtpy/Qt3DRender.py Outdated Show resolved Hide resolved
qtpy/QtCharts.py Show resolved Hide resolved
qtpy/QtDesigner.py Show resolved Hide resolved
qtpy/QtNetworkAuth.py Show resolved Hide resolved
qtpy/QtSerialPort.py Show resolved Hide resolved
qtpy/tests/test_qtdatavisualization.py Outdated Show resolved Hide resolved
@jschueller jschueller force-pushed the pyqt6 branch 3 times, most recently from 4e969b3 to abadf07 Compare October 20, 2021 19:06
This was referenced Oct 21, 2021
Closed
Closed
dalthviz
dalthviz approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller for all the work here!

@dalthviz dalthviz changed the title PR: Add additional Qt modules and more support and tests for PyQt6/PySide6 for existing PR: Add additional Qt modules and more support and tests for PyQt6/PySide6 Oct 21, 2021
@dalthviz dalthviz merged commit cac88c7 into spyder-ide:master Oct 21, 2021
@dalthviz
Copy link
Member

dalthviz commented Oct 21, 2021 •
edited
Loading

I can help take care of it along with #253 after this PR is in, assuming #233 is mostly resolved by then (at least to the point where CI testing is reasonable)

Hi @CAM-Gerlach thank you for the help! I think you can start working on #253 and the missing PyQt6 test support in the CI. If you need any help let us know 👍

@jschueller jschueller deleted the pyqt6 branch October 21, 2021 16:14
@CAM-Gerlach
Copy link
Member

Will do, thanks @dalthviz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz dalthviz approved these changes

Assignees

@jschueller jschueller

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jschueller @dalthviz @CAM-Gerlach